Initial .net 8/9 converstion #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make store review methods async and return Task<bool> Updated IStoreReview interface and implementations across Android, iOS, macOS, tvOS, and UWP to make OpenStoreListing and OpenStoreReviewPage methods asynchronous, returning Task<bool> instead of void. - Changed method signatures in IStoreReview.shared.cs. - Updated Android implementation to return Task.FromResult(true/false). - Modified Apple implementation to use UIApplication.SharedApplication.OpenUrlAsync. - Updated UWP implementation to handle exceptions and return Task<bool>. - Removed PlatformExtensions class from UWP implementation.
Updated README.md to reflect .NET 8+ support for iOS, Android, MacCatalyst, and Windows, and removed outdated platform information. Changed UWP method signatures to return `Task<bool>` for `OpenStoreListing` and `OpenStoreReviewPage`. Updated Android setup instructions in README.md to remove outdated steps. Refactored `CrossStoreReview.shared.cs` and `StoreReviewImplementation` files for modern C# syntax and improved nullability. Simplified `IStoreReview.shared.cs` interface. Updated `StoreReview.Plugin.csproj` with correct metadata. Improved exception handling and logging across all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial .net 8/9 converstion
PR Classification
Code cleanup and modernization of project structure.
PR Summary
This PR simplifies code, updates project configurations, and modernizes platform-specific implementations.
CrossStoreReview.shared.cs: SimplifiedCurrentproperty getter and updated platform-specific compilation symbols.StoreReview.Plugin.csproj: Changed project SDK, updated target frameworks, and added new properties for packaging and platform support.StoreReviewImplementation.android.cs: ReplacedXamarindependencies withMicrosoft.Mauiand updatedOnCompletemethod.StoreReviewImplementation.apple.cs: Added a check for iOS 16.0 or higher.StoreReview.sln: Updated Visual Studio version and removed several test projects and their configurations.