Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add choice to pick certain features #73

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

coquizen
Copy link
Contributor

@coquizen coquizen commented Apr 5, 2021

For the Plus tier of ProtonVPN, the user has the ability to select servers tailored for p2p or Tor networks. However, forewarning: this is my first exposure to the Rust language. The addition seemed fairly simple.

@jamesmcm
Copy link
Owner

jamesmcm commented Apr 5, 2021

Thanks, it looks good :) Did you test it with your account?

@coquizen
Copy link
Contributor Author

coquizen commented Apr 5, 2021

Yes I did in so far as P2P. However not the Tor feature, as I don't exactly know how to test/use it.

@jamesmcm
Copy link
Owner

jamesmcm commented Apr 5, 2021

Cool, as long as the config generation works it should be alright. Seems in the Tor case, it connects to Tor from the VPN server so it's Tor directly integrated.

I'll merge it now and try to make a release tomorrow to see if I can include the PostUp and PreDown script additions too 🙂

@jamesmcm jamesmcm merged commit e32bb00 into jamesmcm:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants