Skip to content

Commit

Permalink
Merge pull request #172 from tagliala/chore/frozen-string-literal
Browse files Browse the repository at this point in the history
Enable frozen string literals
  • Loading branch information
jamesmartin authored Dec 2, 2024
2 parents 0646994 + 792e372 commit 2d8c66c
Show file tree
Hide file tree
Showing 56 changed files with 111 additions and 15 deletions.
14 changes: 0 additions & 14 deletions .rubocop_todo.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

source 'https://rubygems.org'

# Specify your gem's dependencies in inline_svg.gemspec
Expand Down
2 changes: 2 additions & 0 deletions Rakefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "bundler/gem_tasks"
require "rspec/core/rake_task"

Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require_relative "inline_svg/version"
require_relative "inline_svg/action_view/helpers"
require_relative "inline_svg/asset_file"
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/action_view/helpers.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'action_view/helpers' if defined?(Rails)
require 'action_view/context' if defined?(Rails)

Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/asset_file.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
class AssetFile
class FileNotFound < IOError; end
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/finds_asset_paths.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
class FindsAssetPaths
def self.by_filename(filename)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/id_generator.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'digest'

module InlineSvg
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/io_resource.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
module IOResource
def self.===(object)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/propshaft_asset_finder.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
class PropshaftAssetFinder
def self.find_asset(filename)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/railtie.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'rails/railtie'
module InlineSvg
class Railtie < ::Rails::Railtie
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/static_asset_finder.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "pathname"

# Naive fallback asset finder for when sprockets >= 3.0 &&
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
module TransformPipeline
def self.generate_html_from(svg_file, transform_params)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
# Transformations are run in priority order, lowest number first:
def self.built_in_transformations
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class AriaAttributes < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class AriaHidden < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class AriaHiddenAttribute < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class ClassAttribute < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class DataAttributes < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Description < Transformation
def transform(doc)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations/height.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Height < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class IdAttribute < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline
module Transformations
class NoComment < Transformation
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class PreserveAspectRatio < Transformation
def transform(doc)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations/size.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Size < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class StyleAttribute < Transformation
def transform(doc)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations/title.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Title < Transformation
def transform(doc)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Transformation
def self.create_with_value(value)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations/view_box.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class ViewBox < Transformation
def transform(doc)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/transform_pipeline/transformations/width.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg::TransformPipeline::Transformations
class Width < Transformation
def transform(doc)
Expand Down
2 changes: 2 additions & 0 deletions lib/inline_svg/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
VERSION = "2.0.0"
end
2 changes: 2 additions & 0 deletions lib/inline_svg/webpack_asset_finder.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

module InlineSvg
class WebpackAssetFinder
def self.find_asset(filename)
Expand Down
2 changes: 2 additions & 0 deletions spec/asset_file_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg/finds_asset_paths"
require "inline_svg/asset_file"

Expand Down
2 changes: 2 additions & 0 deletions spec/finds_asset_paths_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'pathname'
require "inline_svg"

Expand Down
2 changes: 2 additions & 0 deletions spec/helpers/inline_svg_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg'

class WorkingCustomTransform < InlineSvg::CustomTransformation
Expand Down
2 changes: 2 additions & 0 deletions spec/id_generator_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg/id_generator"

describe InlineSvg::IdGenerator do
Expand Down
2 changes: 2 additions & 0 deletions spec/inline_svg_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg"

class MyCustomTransform
Expand Down
4 changes: 3 additions & 1 deletion spec/io_resource_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg"
require "stringio"
require "tempfile"
Expand Down Expand Up @@ -60,7 +62,7 @@
context 'IO object' do
let(:answer) { 'read' }
let(:rio) { StringIO.new(answer, 'r') }
let(:wio) { StringIO.new('write', 'w') }
let(:wio) { StringIO.new(+'write', 'w') }

instance_exec(&tests)
end
Expand Down
2 changes: 2 additions & 0 deletions spec/propshaft_asset_finder_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg"

describe InlineSvg::PropshaftAssetFinder do
Expand Down
2 changes: 2 additions & 0 deletions spec/static_asset_finder_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg"

describe InlineSvg::StaticAssetFinder do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg/transform_pipeline"

describe InlineSvg::TransformPipeline::Transformations::AriaAttributes do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::AriaHiddenAttribute do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg/transform_pipeline"

describe InlineSvg::TransformPipeline::Transformations::ClassAttribute do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::DataAttributes do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::Description do
Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations/height_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::Height do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::IdAttribute do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::PreserveAspectRatio do
Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations/size_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::Size do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg/transform_pipeline"

describe InlineSvg::TransformPipeline::Transformations::ClassAttribute do
Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations/title_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::Title do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg'
require 'inline_svg/transform_pipeline'

Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations/view_box_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::ViewBox do
Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations/width_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg/transform_pipeline'

describe InlineSvg::TransformPipeline::Transformations::Width do
Expand Down
2 changes: 2 additions & 0 deletions spec/transformation_pipeline/transformations_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'inline_svg'
require 'inline_svg/transform_pipeline'

Expand Down
2 changes: 2 additions & 0 deletions spec/webpack_asset_finder_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require "inline_svg"

describe InlineSvg::WebpackAssetFinder do
Expand Down

0 comments on commit 2d8c66c

Please sign in to comment.