add missing null checks to public constructors

jamesloi · Apr 15, 2015 · 1ab11e9 · 1ab11e9
1 parent 0e72727
commit 1ab11e9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 0 deletions.
diff --git a/src/Ninject/Activation/Caching/ActivationCache.cs b/src/Ninject/Activation/Caching/ActivationCache.cs
@@ -39,6 +39,7 @@ public class ActivationCache : NinjectComponent, IActivationCache, IPruneable
         /// <param name="cachePruner">The cache pruner.</param>
         public ActivationCache(ICachePruner cachePruner)
         {
+            Ensure.ArgumentNotNull(cachePruner, "cachePruner");
             cachePruner.Start(this);
         }
 

diff --git a/src/Ninject/Activation/Pipeline.cs b/src/Ninject/Activation/Pipeline.cs
@@ -36,6 +36,7 @@ public class Pipeline : NinjectComponent, IPipeline
         public Pipeline(IEnumerable<IActivationStrategy> strategies, IActivationCache activationCache)
         {
             Ensure.ArgumentNotNull(strategies, "strategies");
+            Ensure.ArgumentNotNull(activationCache, "activationCache");
             this.Strategies = strategies.ToList();
             this.activationCache = activationCache;
         }
@@ -53,6 +54,7 @@ public Pipeline(IEnumerable<IActivationStrategy> strategies, IActivationCache ac
         public void Activate(IContext context, InstanceReference reference)
         {
             Ensure.ArgumentNotNull(context, "context");
+            Ensure.ArgumentNotNull(reference, "reference");
             if (!this.activationCache.IsActivated(reference.Instance))
             {
                 this.Strategies.Map(s => s.Activate(context, reference));
@@ -67,6 +69,7 @@ public void Activate(IContext context, InstanceReference reference)
         public void Deactivate(IContext context, InstanceReference reference)
         {
             Ensure.ArgumentNotNull(context, "context");
+            Ensure.ArgumentNotNull(reference, "reference");
             if (!this.activationCache.IsDeactivated(reference.Instance))
             {
                 this.Strategies.Map(s => s.Deactivate(context, reference));

diff --git a/src/Ninject/Activation/Strategies/ActivationCacheStrategy.cs b/src/Ninject/Activation/Strategies/ActivationCacheStrategy.cs
@@ -1,6 +1,7 @@
 namespace Ninject.Activation.Strategies
 {
     using Ninject.Activation.Caching;
+    using Ninject.Infrastructure;
 
     /// <summary>
     /// Adds all activated instances to the activation cache.
@@ -18,6 +19,7 @@ public class ActivationCacheStrategy : IActivationStrategy
         /// <param name="activationCache">The activation cache.</param>
         public ActivationCacheStrategy(IActivationCache activationCache)
         {
+            Ensure.ArgumentNotNull(activationCache, "activationCache");
             this.activationCache = activationCache;
         }
 

diff --git a/src/Ninject/Modules/CompiledModuleLoaderPlugin.cs b/src/Ninject/Modules/CompiledModuleLoaderPlugin.cs
@@ -55,6 +55,7 @@ public class CompiledModuleLoaderPlugin : NinjectComponent, IModuleLoaderPlugin
         public CompiledModuleLoaderPlugin(IKernel kernel, IAssemblyNameRetriever assemblyNameRetriever)
         {
             Ensure.ArgumentNotNull(kernel, "kernel");
+            Ensure.ArgumentNotNull(assemblyNameRetriever, "assemblyNameRetriever");
             this.Kernel = kernel;
             this.assemblyNameRetriever = assemblyNameRetriever;
         }