Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache control setting #74

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

fl034
Copy link

@fl034 fl034 commented May 20, 2023

I wanted to add the cache-control header to my uploaded files to improve caching on my clients.

I used the field from the documentation here:
https://learn.microsoft.com/de-de/javascript/api/@azure/storage-blob/blobhttpheaders?view=azure-node-latest#@azure-storage-blob-blobhttpheaders-blobcachecontrol

Since I'm new to TypeScript, please check my PR thoroughly 😄

Copy link
Owner

@jakeFeldman jakeFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I'll publish a new version tomorrow. Thanks for the PR!

@jakeFeldman jakeFeldman merged commit eee32db into jakeFeldman:master Sep 9, 2023
@jakeFeldman
Copy link
Owner

I've published a beta version yarn add strapi-provider-upload-azure-storage@beta Please let me know if you have any issues with this. If not, I will publish a full version in a few days.

@fl034
Copy link
Author

fl034 commented Sep 9, 2023

@jakeFeldman thank you very much. Tested successfully with a missing defaultCacheControl in plugin.js, then with the field present but a missing entry in the .env file. And then with a value that then appeared correctly in the response headers.
All good :)

@jakeFeldman
Copy link
Owner

Great to hear. I will publish a full version later today. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants