Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jakarta.annotation.managedbean tests from Platform TCK #1184

Open
Tracked by #1126
scottmarlow opened this issue Jul 11, 2023 · 6 comments
Open
Tracked by #1126

Remove jakarta.annotation.managedbean tests from Platform TCK #1184

scottmarlow opened this issue Jul 11, 2023 · 6 comments
Assignees
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release

Comments

@scottmarlow
Copy link
Contributor

scottmarlow commented Jul 11, 2023

In support of jakartaee/common-annotations-api#115 remove jakarta.annotation.managedbean Platform TCK tests.

Work is to be done on https://github.com/jakartaee/platform-tck/tree/tckrefactor

git status
On branch tckrefactor

grep -rli jakarta.annotation.ManagedBean --include=*.java
src/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdijsf/OverrideWithPostConstructBean.java
src/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdijsf/OverrideBean.java
appclient/src/main/java/com/sun/ts/tests/appclient/deploy/metadatacomplete/testapp/TestBean.java
jaxrs/src/main/java/com/sun/ts/tests/jaxrs/platform/managedbean/TSAppConfig.java
jaxrs/src/main/java/com/sun/ts/tests/jaxrs/platform/managedbean/ManagedBeanRootResource.java
jaxrs/src/main/java/com/sun/ts/tests/jaxrs/platform/managedbean/StringBuilderProvider.java
signaturetest/src/main/java/com/sun/ts/tests/signaturetest/caj/CAJSigTest.java
jms/src/main/java/com/sun/ts/tests/jms/ee20/cditests/ejbweb/MyManagedBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/misc/moduleName/appclientejb/ModuleMBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/misc/moduleName/twowars/ModuleMBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/misc/moduleName/twojars/ModuleMBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/invocationcontext/InvocationContextInterceptorBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/invocationcontext/InvocationContextBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/business/InterceptorOverride34Bean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/business/InterceptorOverrideBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/business/InterceptorBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdi/OverrideWithPostConstructBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdi/OverrideBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecycle/InterceptorOverride34Bean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecycle/AManagedBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecycle/InterceptorOverrideBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecycle/InterceptorBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/assembly/appres/common/AppResManagedBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/assembly/mbean/appclient/TwoManagedBean.java
ejb30/src/main/java/com/sun/ts/tests/ejb30/assembly/mbean/appclient/OneManagedBean.java

The above tests need to be removed or updated to not reference jakarta.annotation.ManagedBean.

@scottmarlow scottmarlow added the 11.0 Issues related to the Jakarta EE 11 Platform TCK release label Jul 11, 2023
@edburns
Copy link
Contributor

edburns commented Jul 19, 2023

Hello @scottmarlow , can you please create a label "jea-linked" with color #0099cc? I want to attach this label to this issue because I have linked it to Azure Boards AB#118.

@scottmarlow
Copy link
Contributor Author

Hello @scottmarlow , can you please create a label "jea-linked" with color #0099cc? I want to attach this label to this issue because I have linked it to Azure Boards AB#118.

@edburns done via jea-linked for https://github.com/jakartaee/platform-tck/issues/1184#issuecomment-1642389027

@edburns
Copy link
Contributor

edburns commented Jul 15, 2024

Please confirm this sketch for how a new helper could complete the task.

  1. Learn how to run the Jakarta 10 TCK against GlassFish 7.
  2. Ensure it runs successfully, including the tests to be removed under this issue.
  3. Perform the removal action.
  4. Ensure it still runs successfully, and the tests are removed.

Also, please confirm the changes for this issue should be made to the master branch of https://github.com/jakartaee/platform-tck .

scottmarlow added a commit to scottmarlow/jakartaee-tck that referenced this issue Sep 30, 2024
…otation-api from 2.1.1 to 3.0.0 (jakartaee#1467)" until we address jakartaee#1184

This reverts commit dfa720a.
scottmarlow added a commit that referenced this issue Sep 30, 2024
Address #1545 by revert "Bump jakarta.annotation:jakarta.annotation-api from 2.1.1 to 3.0.0 (#1467)" until we address #1184
@brideck brideck self-assigned this Oct 2, 2024
@gurunrao gurunrao moved this from Ready to Assign to In progress in Jakarta EE11 TCK Release Oct 8, 2024
@arjantijms
Copy link
Contributor

At the moment we still seem to have 5 hits for "@ManagedBean" in the project.

@brideck
Copy link
Contributor

brideck commented Jan 21, 2025

At the moment we still seem to have 5 hits for "@ManagedBean" in the project.

I see 3 in my local copy, and a lot of it is weird to me.

./src/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdijsf/OverrideBean.java:@ManagedBean("OverrideBean")
./src/com/sun/ts/tests/ejb30/lite/packaging/war/mbean/interceptor/lifecyclecdijsf/OverrideWithPostConstructBean.java:@ManagedBean("OverrideWithPostConstructBean")

The source tree that I did the 1558 changes from didn't even have a lifecyclecdijsf sub-folder, so I don't know what this is. It should obviously be removed, though.

I'll also point out that I had this note in my PR:

Note: This does leave behind one awkward test in ejb30/lite/packaging/war/mbean/interceptor/lifecycleejbcdi, which despite the location is not actually a ManagedBean test in any way.

Despite that, it looks like lifecycleejbcdi has been removed, except for a beans.xml file that was never needed in the first place.

--

The other one I see is :

./tcks/apis/messaging/messaging-outside-container/src/main/java/com/sun/ts/tests/jms/ee20/cditests/ejbweb/MyManagedBean.java:@ManagedBean(value = "mybean")

That one was converted to a CDI bean in my PR, but that change was apparently lost when the JMS tests were transformed,

--

What are the other two you're seeing?

@arjantijms
Copy link
Contributor

What are the other two you're seeing?

I currently see these:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release
Projects
Status: In progress
Development

No branches or pull requests

4 participants