-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-info to the api artifacts, update to Java SE 11 #565
Conversation
Update the root readme Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
…ory and imagesdir Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
Signed-off-by: starksm64 <starksm64@gmail.com>
IIUC, this also makes Not sure if that's a good thing or a bad thing, but it should be a conscious choice. |
It is essentially required as we depend on artifacts that are being built with Java 11 (annotations 2.1), and it is the baseline Java version for all major specification versions going into EE10. |
I mean, I'm fine with making it 11+ only, especially if we don't have a choice :-) But it would be good if it was highlighted in the PR title / commit message. |
Signed-off-by: starksm64 <starksm64@gmail.com>
Ok, added updating to Java SE 11 in PR title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, though my understanding of JPMS is virtually zero :-)
I'm keeping this open for more reviewers. I originally thought maybe this should be a draft because it uses an RC version of Interceptors, but we already have a non-final version of Annotations, so that's fine. Also looking at the list of commits, I think I'd merge this using "Squash and merge". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although my understanding of JPMS is not the deepest.
There still an outstanding question about moving to the Java SE 11 base, but we will go with it for the RC so that we can get feedback on potential problems. |
This relies on the staged 2.0.1-RC1 jakarta.interceptor:jakarta.interceptor-api artifact