Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move cassandra implementation to internal package #6639

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Jan 31, 2025

Which problem is this PR solving?

Description of the changes

  • This PR moves the implementation from plugin/storage/ to internal/storage/

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added the changelog:breaking-change Change that is breaking public APIs or established behavior label Jan 31, 2025
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner January 31, 2025 00:09
@mahadzaryab1
Copy link
Collaborator Author

@yurishkuro do we want the v1 subdirectory or should it just go under internal/storage/?

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (6d8c70e) to head (84572a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6639   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         365      365           
  Lines       20609    20609           
=======================================
  Hits        19774    19774           
  Misses        636      636           
  Partials      199      199           
Flag Coverage Δ
badger_v1 9.91% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1-manual 14.92% <ø> (ø)
cassandra-4.x-v2-auto 1.83% <ø> (ø)
cassandra-4.x-v2-manual 1.83% <ø> (ø)
cassandra-5.x-v1-manual 14.92% <ø> (ø)
cassandra-5.x-v2-auto 1.83% <ø> (ø)
cassandra-5.x-v2-manual 1.83% <ø> (ø)
elasticsearch-6.x-v1 19.30% <ø> (ø)
elasticsearch-7.x-v1 19.38% <ø> (ø)
elasticsearch-8.x-v1 19.55% <ø> (ø)
elasticsearch-8.x-v2 1.84% <ø> (ø)
grpc_v1 10.89% <ø> (ø)
grpc_v2 7.88% <ø> (ø)
kafka-3.x-v1 10.21% <ø> (ø)
kafka-3.x-v2 1.84% <ø> (ø)
memory_v2 1.84% <ø> (ø)
opensearch-1.x-v1 19.43% <ø> (ø)
opensearch-2.x-v1 19.43% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/dependabot.yml Outdated Show resolved Hide resolved
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
.github/dependabot.yml Outdated Show resolved Hide resolved
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please check if the docs have links to the old location.

Makefile.Docker.mk Outdated Show resolved Hide resolved
@mahadzaryab1
Copy link
Collaborator Author

lgtm. Please check if the docs have links to the old location.

Don't see anything else

@yurishkuro
Copy link
Member

Don't see anything else

I mean in the docs repo, e.g.

content/docs/1.40/deployment.md
418:MODE=test sh ./plugin/storage/cassandra/schema/create.sh | cqlsh
734:For more information, please refer to [jaeger/plugin/storage/grpc](https://github.com/jaegertracing/jaeger/tree/master/plugin/storage/grpc).
829:[storage.proto]: https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/grpc/proto/storage.proto

@mahadzaryab1
Copy link
Collaborator Author

Don't see anything else

I mean in the docs repo, e.g.

content/docs/1.40/deployment.md
418:MODE=test sh ./plugin/storage/cassandra/schema/create.sh | cqlsh
734:For more information, please refer to [jaeger/plugin/storage/grpc](https://github.com/jaegertracing/jaeger/tree/master/plugin/storage/grpc).
829:[storage.proto]: https://github.com/jaegertracing/jaeger/blob/main/plugin/storage/grpc/proto/storage.proto

Ah okay - I can fix that

@mahadzaryab1 mahadzaryab1 merged commit 619a9f7 into jaegertracing:main Jan 31, 2025
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the move-cassandra branch January 31, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior storage/cassandra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants