Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test: plugin/storage/badger/samplingstore #5094

Merged
merged 9 commits into from
Jan 15, 2024

Conversation

akagami-harsh
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • fixed flaky test
  • fixed a small typo

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh requested a review from a team as a code owner January 11, 2024 20:43
Copy link

github-actions bot commented Jan 11, 2024

Test Results

2 086 tests  ±0   2 076 ✅ ±0   1m 8s ⏱️ -1s
  220 suites ±0      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit a91d7e5. ± Comparison against base commit 09f7a30.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9f614c) 95.56% compared to head (a91d7e5) 95.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5094      +/-   ##
==========================================
- Coverage   95.56%   95.55%   -0.02%     
==========================================
  Files         319      319              
  Lines       18376    18379       +3     
==========================================
+ Hits        17561    17562       +1     
- Misses        654      655       +1     
- Partials      161      162       +1     
Flag Coverage Δ
cassandra-3.x 25.59% <ø> (ø)
cassandra-4.x 25.59% <ø> (ø)
elasticsearch-5.x 19.86% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (ø)
elasticsearch-7.x 20.01% <ø> (ø)
elasticsearch-8.x 20.10% <ø> (ø)
grpc-badger 19.52% <100.00%> (ø)
kafka 14.10% <ø> (ø)
opensearch-1.x 20.01% <ø> (ø)
opensearch-2.x 20.01% <ø> (ø)
unittests 93.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Jan 15, 2024
@yurishkuro yurishkuro merged commit 126c49b into jaegertracing:main Jan 15, 2024
39 of 40 checks passed
@akagami-harsh akagami-harsh deleted the fix-flaky-test branch May 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Flaky test: plugin/storage/badger/samplingstore
2 participants