Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable goimports linter #3692

Merged
merged 1 commit into from
May 21, 2022
Merged

Enable goimports linter #3692

merged 1 commit into from
May 21, 2022

Conversation

mmorel-35
Copy link
Contributor

Short description of the changes

  • Enable goimports linter, this is doing the same as ./scripts/import-order-cleanup.sh

Signed-off-by: Matthieu MOREL mmorel-35@users.noreply.github.com

Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #3692 (3f55481) into main (07af654) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3692   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files         268      268           
  Lines       15745    15745           
=======================================
  Hits        15330    15330           
  Misses        328      328           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07af654...3f55481. Read the comment docs.

@mmorel-35 mmorel-35 marked this pull request as ready for review May 21, 2022 07:23
@mmorel-35 mmorel-35 requested a review from a team as a code owner May 21, 2022 07:23
@mmorel-35 mmorel-35 requested a review from vprithvi May 21, 2022 07:23
@yurishkuro yurishkuro merged commit f2c6bda into jaegertracing:main May 21, 2022
@mmorel-35 mmorel-35 deleted the linter/goimports branch May 21, 2022 14:58
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants