-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set permissions on the workflows #4017
Labels
Comments
yurishkuro
added a commit
that referenced
this issue
Nov 1, 2022
See #4017 Signed-off-by: Yuri Shkuro <github@ysh.us>
Permissions were added in 029a0f, so changing the global settings back to read-only. cc @jkowall |
yurishkuro
added a commit
that referenced
this issue
Nov 9, 2022
Turns out `read-all|write-all` is invalid syntax. Narrowing this further to just deploy perms. #4017
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Mar 5, 2023
See jaegertracing#4017 Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Mar 5, 2023
Turns out `read-all|write-all` is invalid syntax. Narrowing this further to just deploy perms. jaegertracing#4017 Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Last release was failing with
Error: Resource not accessible by integration
. Turns out it was due to recent change to permissions for the github token. I was able to unblock the release by changing the permissions back to read&write:However, security audit recommendation is to have that setting at read-only, which should be sufficient for most workflows except for
ci-release
, which needs to upload the binaries to the release page.Docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
The text was updated successfully, but these errors were encountered: