Spans Table View #781

vvvprabhakar · 2021-07-05T09:51:28Z

Signed-off-by: vvvprabhakar vvvprabhakar@gmail.com

Why trace span table? Issue(#690)
A trace with many spans trace (~20K) spans can be broken down into pieces and analyzed. Have a link with traceTimeline View as well to link both views and get the analysis of trace
Gives a detailed view of a service or an operation and its impact on a trace,

What can we achieve?

Filter Spans with multiple serviceName values
Filter Spans with multiple OperationName values
Filter with both ServiceName and OperationName
Sort based on duration and startTime
Each row in the table has spanID link which will take the user to that particular span in traceTimelineView
Either search with text on serviceName and OperatioName Columns
Pagination for the spans

What can we improve from here?

We can add SelfTime in the table as a column and make it sortable

Dependencies Used

Used antd for table

**

**

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

…into ISSUE_690

jpkrohling · 2021-07-07T10:42:49Z

The tests seem to be failing. Are you able to sort them out?

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar · 2021-07-14T12:03:21Z

@jpkrohling Need your help in fixing this unit case(1 case)

rubenvp8510 · 2021-07-15T04:15:11Z

Hi @vvvprabhakar there is a small bug on the AltViewOptions tests, in the 'track dropdown menu' case:

Check this commit I did on my own fork:

rubenvp8510@09664d9

It was a coincidence that in the past link2.length === links2.length, but now that you added another entry the bug comes up and the test start to fail.

With this change your tests should pass, at least it pass on my local. :)

The code overall looks good, Once the tests are fixed I'll do another review.

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar · 2021-07-15T10:48:25Z

@rubenvp8510 Thanks a lot man

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

…into ISSUE_690

vvvprabhakar · 2021-07-17T06:35:43Z

@rubenvp8510 can you review once
I have optimised the filtering logic also

vvvprabhakar · 2021-07-21T06:54:13Z

Once you get time can you please review this

jpkrohling · 2021-07-21T07:34:51Z

ping @rubenvp8510

codecov · 2021-07-21T07:46:48Z

Codecov Report

Merging #781 (5d9eed2) into master (0c1fcd1) will increase coverage by 0.01%.
The diff coverage is 96.59%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   95.07%   95.09%   +0.01%     
==========================================
  Files         230      231       +1     
  Lines        7010     7097      +87     
  Branches     1745     1759      +14     
==========================================
+ Hits         6665     6749      +84     
- Misses        339      342       +3     
  Partials        6        6

Impacted Files	Coverage Δ
...mponents/TracePage/TraceStatistics/tableValues.tsx	`94.44% <ø> (ø)`
packages/jaeger-ui/src/utils/tracking/utils.tsx	`80.00% <ø> (ø)`
...i/src/components/TracePage/TraceSpanView/index.tsx	`95.08% <95.08%> (ø)`
...nents/TracePage/TracePageHeader/AltViewOptions.tsx	`100.00% <100.00%> (ø)`
...racePage/TracePageHeader/TracePageHeader.track.tsx	`100.00% <100.00%> (ø)`
...kages/jaeger-ui/src/components/TracePage/index.tsx	`100.00% <100.00%> (ø)`
packages/jaeger-ui/src/utils/date.tsx	`94.36% <100.00%> (+1.91%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b651416...5d9eed2. Read the comment docs.

rubenvp8510 · 2021-07-22T06:25:34Z

I'll review this tomorrow morning, overall looks good but I want to see it on detail

packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.tsx

rubenvp8510 · 2021-07-30T04:58:54Z

packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.tsx

+      const operationNames = serviceNameOperationsMap.get(span.process.serviceName) || [];
+      operationNames.push(span.operationName);
+      serviceNameOperationsMap.set(span.process.serviceName, operationNames);
+      return { serviceNamesList, operationNamesList };


Why are your returning this ? where this is used?

We are not using it removed

rubenvp8510 · 2021-07-30T05:02:12Z

Can we add a couple of tests to the new views? at least basic testing?

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar · 2021-08-09T18:30:46Z

@rubenvp8510 made the changes you proposed
Can you just reverify them once you get the time?
Thanks in Adavance

rubenvp8510 · 2021-08-12T05:07:02Z

Thanks for doing the changes!

I'll review tomorrow morning!

vvvprabhakar · 2021-08-17T08:21:02Z

Did you get a chance to see this?

rubenvp8510 · 2021-08-18T02:50:43Z

packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.test.js

+  it('Should change value when onChange was called', () => {
+    const event = ['service2'];
+    wrapper = shallow(<TraceSpanView {...defaultProps} />);
+    // wrapper.state('filtered.process.serviceName', ['service1', 'service2']);


Remove this comment please.

rubenvp8510 · 2021-08-18T03:19:25Z

Small comment, overall looks good. I just need to do a quick smoke test and will merge.

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar · 2021-08-18T09:36:53Z

@rubenvp8510 Removed the line and pushed it
Thanks for taking time and reviewing it

vvvprabhakar · 2021-08-23T10:50:09Z

@rubenvp8510 did you get time to see this ?

rubenvp8510 · 2021-08-23T13:24:35Z

I've already approved but it will be good if we can increase the coverage a little bit. may be we can write tests for https://github.com/jaegertracing/jaeger-ui/pull/781/files#diff-00ec9fc101b0b3db820b0352d451f88833915d001216cf78d40ac1178a65be28R148

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar · 2021-08-29T19:21:53Z

Thanks for reviewing it
@rubenvp8510 updated the test cases also
When you have free time just please do the review, sorry for bothering you

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

…into ISSUE_690

vvvprabhakar · 2021-08-30T05:49:16Z

Coverage was 0.05% less, so covered it, when you have time just check this @rubenvp8510
Thanks

rubenvp8510

Thanks!

filter and selection options for spans

f28f7d5

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

vvvprabhakar requested review from everett980, rubenvp8510 and tiffon as code owners July 5, 2021 09:51

vvvprabhakar added 3 commits July 5, 2021 15:27

Merge branch 'master' into ISSUE_690

37b402b

eslint issues

e9b4b91

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Merge branch 'ISSUE_690' of https://github.com/vvvprabhakar/jaeger-ui …

07951ce

…into ISSUE_690

eslint issues

caa30a0

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

rubenvp8510 self-assigned this Jul 15, 2021

fixing test case

8396bba

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Merge branch 'master' into ISSUE_690

1a153f0

vvvprabhakar changed the title ~~Spans Table View~~ WIP:Spans Table View Jul 16, 2021

vvvprabhakar added 2 commits July 17, 2021 12:00

optimised the filtering logic

66435d4

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Merge branch 'ISSUE_690' of https://github.com/vvvprabhakar/jaeger-ui …

a7b94ff

…into ISSUE_690

vvvprabhakar changed the title ~~WIP:Spans Table View~~ Spans Table View Jul 17, 2021

rubenvp8510 reviewed Jul 30, 2021

View reviewed changes

packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.tsx Outdated Show resolved Hide resolved

rubenvp8510 reviewed Jul 30, 2021

View reviewed changes

packages/jaeger-ui/src/components/TracePage/TraceSpanView/index.tsx Outdated Show resolved Hide resolved

rubenvp8510 reviewed Jul 30, 2021

View reviewed changes

vvvprabhakar added 2 commits August 9, 2021 13:55

PR comments and Tests

65a9f81

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

unit test cases

c3fa88b

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Merge branch 'master' into ISSUE_690

a902c0d

vvvprabhakar requested a review from rubenvp8510 August 10, 2021 06:31

Merge branch 'master' into ISSUE_690

8e912d2

rubenvp8510 reviewed Aug 18, 2021

View reviewed changes

removed the commented line

009f960

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

rubenvp8510 previously approved these changes Aug 23, 2021

View reviewed changes

rubenvp8510 enabled auto-merge (squash) August 23, 2021 13:25

unit test cases

9a78bc5

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

auto-merge was automatically disabled August 29, 2021 19:20
Head branch was pushed to by a user without write access

vvvprabhakar dismissed rubenvp8510’s stale review via 9a78bc5 August 29, 2021 19:20

Merge branch 'master' into ISSUE_690

7b28b2b

rubenvp8510 enabled auto-merge (squash) August 30, 2021 03:50

vvvprabhakar added 2 commits August 30, 2021 11:16

unit test cases & removed unnecessary changes

7328d6c

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Merge branch 'ISSUE_690' of https://github.com/vvvprabhakar/jaeger-ui …

5d9eed2

…into ISSUE_690

auto-merge was automatically disabled August 30, 2021 05:47
Head branch was pushed to by a user without write access

rubenvp8510 approved these changes Aug 31, 2021

View reviewed changes

rubenvp8510 merged commit ad60380 into jaegertracing:master Aug 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spans Table View #781

Spans Table View #781

vvvprabhakar commented Jul 5, 2021 •

edited

Loading

jpkrohling commented Jul 7, 2021

vvvprabhakar commented Jul 14, 2021

rubenvp8510 commented Jul 15, 2021 •

edited

Loading

vvvprabhakar commented Jul 15, 2021

vvvprabhakar commented Jul 17, 2021

vvvprabhakar commented Jul 21, 2021

jpkrohling commented Jul 21, 2021

codecov bot commented Jul 21, 2021 •

edited

Loading

rubenvp8510 commented Jul 22, 2021

rubenvp8510 Jul 30, 2021 •

edited

Loading

vvvprabhakar Aug 3, 2021

rubenvp8510 commented Jul 30, 2021

vvvprabhakar commented Aug 9, 2021

rubenvp8510 commented Aug 12, 2021

vvvprabhakar commented Aug 17, 2021

rubenvp8510 Aug 18, 2021

rubenvp8510 commented Aug 18, 2021

vvvprabhakar commented Aug 18, 2021

vvvprabhakar commented Aug 23, 2021

rubenvp8510 commented Aug 23, 2021 •

edited

Loading

vvvprabhakar commented Aug 29, 2021 •

edited

Loading

vvvprabhakar commented Aug 30, 2021

rubenvp8510 left a comment

Spans Table View #781

Spans Table View #781

Conversation

vvvprabhakar commented Jul 5, 2021 • edited Loading

jpkrohling commented Jul 7, 2021

vvvprabhakar commented Jul 14, 2021

rubenvp8510 commented Jul 15, 2021 • edited Loading

vvvprabhakar commented Jul 15, 2021

vvvprabhakar commented Jul 17, 2021

vvvprabhakar commented Jul 21, 2021

jpkrohling commented Jul 21, 2021

codecov bot commented Jul 21, 2021 • edited Loading

Codecov Report

rubenvp8510 commented Jul 22, 2021

rubenvp8510 Jul 30, 2021 • edited Loading

Choose a reason for hiding this comment

vvvprabhakar Aug 3, 2021

Choose a reason for hiding this comment

rubenvp8510 commented Jul 30, 2021

vvvprabhakar commented Aug 9, 2021

rubenvp8510 commented Aug 12, 2021

vvvprabhakar commented Aug 17, 2021

rubenvp8510 Aug 18, 2021

Choose a reason for hiding this comment

rubenvp8510 commented Aug 18, 2021

vvvprabhakar commented Aug 18, 2021

vvvprabhakar commented Aug 23, 2021

rubenvp8510 commented Aug 23, 2021 • edited Loading

vvvprabhakar commented Aug 29, 2021 • edited Loading

vvvprabhakar commented Aug 30, 2021

rubenvp8510 left a comment

Choose a reason for hiding this comment

vvvprabhakar commented Jul 5, 2021 •

edited

Loading

rubenvp8510 commented Jul 15, 2021 •

edited

Loading

codecov bot commented Jul 21, 2021 •

edited

Loading

rubenvp8510 Jul 30, 2021 •

edited

Loading

rubenvp8510 commented Aug 23, 2021 •

edited

Loading

vvvprabhakar commented Aug 29, 2021 •

edited

Loading