Sequester zoom concerns to ZoomManager in plexus #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 91.44% 91.49% +0.05%
==========================================
Files 173 173
Lines 3904 3904
Branches 892 892
==========================================
+ Hits 3570 3572 +2
+ Misses 298 296 -2
Partials 36 36
Continue to review full report at Codecov.
|
everett980
approved these changes
Jul 9, 2019
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Sequester zoom concerns to ZoomManager in plexus Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Managing the zoom is spread throughout the
DirectedGraphcomponent. This PR collects that functionality intoZoomManager.This is in preparation for adding layers to plexus.
Short description of the changes
Collect functionality for managing d3-zoom into
ZoomManagerin theplexuspackage. This does not change the public API of the package.