-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap span tag values #388
Wrap span tag values #388
Conversation
I can see arguments for either type of display, e.g. a huge value that's not relevant to you at the moment will mess up the display. Maybe this should be toggled somehow. |
Signed-off-by: Elan Kugelmass <epkugelmass@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 89.06% 89.06%
=======================================
Files 162 162
Lines 3658 3658
Branches 831 831
=======================================
Hits 3258 3258
Misses 364 364
Partials 36 36 Continue to review full report at Codecov.
|
I agree with you. This measly PR represents the limit of what I'm able to contribute to this project right now. Maybe we should close this in favor of a more detailed issue. |
@yurishkuro values don't get very large due to truncation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Wrap span tag values Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Which problem is this PR solving?
Long tag values are difficult to read as they are rendered in a scroll box.
Short description of the changes
Wrap the tag value instead.
From
to
Signed-off-by: Elan Kugelmass epkugelmass@gmail.com