Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted CircularProgressbar.tsx to functional component #2624

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ADI-ROXX
Copy link
Contributor

@ADI-ROXX ADI-ROXX commented Jan 24, 2025

Which problem is this PR solving?

Description of the changes

  • Since the class was a react pure component, I have added memoization to the functional component instead of directly exporting it as a simple function.

How was this change tested?

  • npm run lint
  • npm run test

Checklist

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 24, 2025 17:46
@ADI-ROXX ADI-ROXX requested review from albertteoh and removed request for a team January 24, 2025 17:46
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (2d880b4) to head (17dd2a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2624   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         255      255           
  Lines        7738     7740    +2     
  Branches     1988     1937   -51     
=======================================
+ Hits         7476     7478    +2     
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: cs-308-2023 <adityaruhela2003@gmail.com>
@ADI-ROXX ADI-ROXX changed the title Converted CircularLoader.tsx to functional component Converted CircularProgressbar.tsx to functional component Jan 24, 2025
@yurishkuro
Copy link
Member

please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants