reimplemented MonitorATMServicesViewImpl in react functions with hook #2570
+319
−399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
|
@yurishkuro would you please review it!!! |
| @@ -467,7 +425,7 @@ export function mapStateToProps(state: ReduxState): TReduxProps { | |||
| }; | |||
| } | |||
|
|
|||
| export function mapDispatchToProps(dispatch: Dispatch<ReduxState>): TDispatchProps { | |||
| export function mapDispatchToProps(dispatch: Dispatch<ReduxState>) { | |||
There was a problem hiding this comment.
With functional components, you can use hooks like useDispatch instead of mapDispatchToProps. Similarly, useSelector for mapStateToProps. That would be a better approach, imo
There was a problem hiding this comment.
A lot of tests are removed. They gotta be replaced?
|
There are some regressions.
|
| store.set('lastAtmSearchSpanKind', selectedSpanKind); | ||
| store.set('lastAtmSearchTimeframe', selectedTimeFrame); | ||
| store.set('lastAtmSearchService', this.getSelectedService()); | ||
| store.set('lastAtmSearchService', getSelectedService()); |
There was a problem hiding this comment.
This is setting the last selected service to store on selecting a new service. The expected behavior is to set the currently selected service to store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Issue #2013
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test