Use import from /dist/ instead of symlink #2135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is an insignificant issue, so I didn't open an issue ticket beforehand. There's a symlink here to a file in node_modules. It's small problem, but the symlink is unnecessary. I came across this because I have this repo as a submodule in another project, and back up those changes (and a lot of other repos) with
rsync
, the sync checks output to see if there are errors. I would guess this also causes problems on Windows without WSL.Description of the changes
Change the import. This Just Works™ in Vite.
How was this change tested?
yarn lint && yarn test && yarn start
, andyarn build
, and greppingreact-vis
clases in the assets.Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test