Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tooltip for Elasticsearch tag queries #1809

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Improve tooltip for Elasticsearch tag queries #1809

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
815db6d
Improve tooltip for Elasticsearch tag queries
pavolloffay Sep 20, 2023
c2d2589
Fix
pavolloffay Sep 20, 2023
2242bf0
Review comments
pavolloffay Sep 20, 2023
65dc04e
Fix
pavolloffay Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/jaeger-ui/src/components/SearchTracePage/SearchForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,17 @@ export class SearchFormImpl extends React.PureComponent {
<li>
Values containing whitespace or equal-sign &apos=&apos should be enclosed in quotes
</li>
<li>
Elasticsearch/OpenSearch storage requires escaping{' '}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to belong in the tool tip. The only escaping needed in the ui input is so that the ui parser can pick apart the right strings. If those strings still need additional escaping for storage, it should be handled by the storage implementation, transparently to the user.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ES storage uses on purpose regex terms (it regex support was added to ES storage some time ago).

The goal here is to document this to let people know that escaping is needed for exact match queries.

<a
href="https://lucene.apache.org/core/9_0_0/core/org/apache/lucene/util/automaton/RegExp.html"
rel="noopener noreferrer"
target="_blank"
>
reserved characters
</a>{' '}
for exact match queries.
</li>
</ul>,
]}
content={
Expand Down