Fix linting warnings for no-unused-vars, no-var-requires #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 17, 2023 11:56
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
…TreeNode.tsx file Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
433175d to
5c45ede
Compare
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
yurishkuro
reviewed
Sep 17, 2023
.eslintrc.js
Outdated
| '@typescript-eslint/no-unused-vars': 'warn', | ||
| '@typescript-eslint/no-var-requires': 'warn', | ||
| '@typescript-eslint/no-empty-function': 0, | ||
| '@typescript-eslint/ban-types': 'warn', | ||
| '@typescript-eslint/ban-ts-comment': 'warn', | ||
| '@typescript-eslint/ban-ts-comment': 0, |
There was a problem hiding this comment.
this is not fixing the warnings, it's suppressing them. Please remove from this PR.
There was a problem hiding this comment.
I will going to work on this PR gradually, currently I'm working on cleaning the ban-types. Although, the ban-ts comment only used three time on project and it used only to suppress react-vis problem.
Signed-off-by: priyanshu-kun <priyanshushrama709@gmail.com>
yurishkuro
reviewed
Sep 17, 2023
| const critcalPathViewBounds = getViewedBounds(each.section_start, each.section_end); | ||
| const criticalPathViewStart = critcalPathViewBounds.start; | ||
| const criticalPathViewEnd = critcalPathViewBounds.end; | ||
| return ( | ||
| <div | ||
| key={index} | ||
| key={each.spanId} |
There was a problem hiding this comment.
This is not semantically equivalent change
There was a problem hiding this comment.
semantically equivalent change? Should I put type number here as key?
There was a problem hiding this comment.
Why are you changing it in the first place? I would leave it for another PR.
| @@ -10,13 +10,13 @@ | |||
| // distributed under the License is distributed on an "AS IS" BASIS, | |||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
| // limitations under the License | |||
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Priyanshu Sharma <priyanshushrama709@gmail.com>
yurishkuro
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test