Avoid use of require() in default-config.tsx #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
previously approved these changes
Mar 1, 2023
|
This needs to be an import for an eventual build system switch, since Vite uses ES modules. It also helps make things more consistent. The UI package version in the About Jaeger dropdown still shows up. Signed-off-by: Máté Szabó <mszabo@fandom.com>
4779199 to
5b418d3
Compare
|
Oops, fixed. |
|
lots of other lint errors |
|
That's odd... the test run failed but there's no test marked as explicitly failed, perhaps the job itself got killed off. The noise in tests is from the Enzyme adapter, since that one is originally for React 17 and with Enzyme being effectively dead, there's no React 18 adapter as far as I'm aware, hence the warnings logged about it using a deprecated API. It's something to look into as a next step. The tests do pass for me locally. I'll push an empty commit to re-trigger them and see if that helps. |
Signed-off-by: Máté Szabó <mszabo@fandom.com>
|
Amusingly, it seems Codecov crashes on empty commits: https://app.codecov.io/github/jaegertracing/jaeger-ui/commit/984f8a24b2e11d3d214a876d50f5a179650218d5 However, the retry seems to have helped. |
yurishkuro
approved these changes
Mar 1, 2023
|
🎉 |
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this pull request
Apr 18, 2023
## Which problem is this PR solving? - Split from jaegertracing#1212 ## Short description of the changes This needs to be an import for an eventual build system switch, since Vite uses ES modules. It also helps make things more consistent. The UI package version in the About Jaeger dropdown still shows up. --------- Signed-off-by: Máté Szabó <mszabo@fandom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This needs to be an import for an eventual build system switch, since Vite uses ES modules. It also helps make things more consistent.
The UI package version in the About Jaeger dropdown still shows up.