Abstract access to injected globals #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1224 +/- ##
==========================================
+ Coverage 95.44% 95.47% +0.03%
==========================================
Files 243 244 +1
Lines 7570 7578 +8
Branches 1898 1898
==========================================
+ Hits 7225 7235 +10
+ Misses 345 343 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yurishkuro
reviewed
Feb 28, 2023
| @@ -0,0 +1,35 @@ | |||
| // Copyright (c) 2023 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2023 Uber Technologies, Inc. | |
| // Copyright (c) 2023 The Jaeger Authors. |
Create a wrapper module for accessing globals injected by the build system. This makes it easier to rename or adjust those later. Signed-off-by: Máté Szabó <mszabo@fandom.com>
dda3b97 to
b9067d0
Compare
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this pull request
Apr 18, 2023
## Which problem is this PR solving? - Split from jaegertracing#1212 ## Short description of the changes Create a wrapper module for accessing globals injected by the build system. This makes it easier to rename or adjust those later. Signed-off-by: Máté Szabó <mszabo@fandom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Create a wrapper module for accessing globals injected by the build system. This makes it easier to rename or adjust those later.