Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error when changing search form lookback dropdown #325

Closed
tiffon opened this issue Feb 7, 2019 · 0 comments
Closed

JS error when changing search form lookback dropdown #325

tiffon opened this issue Feb 7, 2019 · 0 comments
Assignees
Labels

Comments

@tiffon
Copy link
Member

tiffon commented Feb 7, 2019

Requirement - what kind of business use case are you trying to solve?

Avoid JavaScript errors on the search page.

Problem - what in Jaeger blocks you from solving the requirement?

Currently, the following JS error is thrown on when changing the lookback search form field:

Uncaught TypeError: _this2.props.onFocus is not a function
    at Select.js:1029
(anonymous) @ Select.js:1029
setTimeout (async)
timeoutFocus @ Select.js:1028
onOuterFocus @ Select.js:620
callCallback @ react-dom.development.js:107
invokeGuardedCallbackDev @ react-dom.development.js:144
invokeGuardedCallback @ react-dom.development.js:191
invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:205
executeDispatch @ react-dom.development.js:472
executeDispatchesInOrder @ react-dom.development.js:497
executeDispatchesAndRelease @ react-dom.development.js:597
executeDispatchesAndReleaseTopLevel @ react-dom.development.js:610
forEachAccumulated @ react-dom.development.js:577
runEventsInBatch @ react-dom.development.js:753
runExtractedEventsInBatch @ react-dom.development.js:763
handleTopLevel @ react-dom.development.js:4416
batchedUpdates @ react-dom.development.js:13125
batchedUpdates @ react-dom.development.js:2036
dispatchEvent @ react-dom.development.js:4498
interactiveUpdates @ react-dom.development.js:13187
interactiveUpdates @ react-dom.development.js:2057
dispatchInteractiveEvent @ react-dom.development.js:4474

Proposal - what do you suggest to solve the problem or improve the existing situation?

Replace the null with a no-op function in the redux-form-field-adapter.js.

onBlur={isValidatedInput ? onBlur : null}
onFocus={isValidatedInput ? onFocus : null}

Any open questions to address

N /A

@tiffon tiffon added the bug label Feb 7, 2019
@everett980 everett980 self-assigned this Feb 7, 2019
tiffon added a commit that referenced this issue Feb 15, 2019
Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Feb 15, 2019
@ghost ghost added the review label Feb 15, 2019
tiffon added a commit that referenced this issue Feb 15, 2019
* Fix JS errors on search form dropdowns (#325)
* Fix formatting issue

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost removed the review label Feb 15, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
…cing#329)

* Fix JS errors on search form dropdowns (jaegertracing#325)
* Fix formatting issue

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants