This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Use the verify task in google-formatter instead of checkstyle #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The checkstyle checks weren't 100pc in sync with the formatter checks, so we solely rely on the formatter's checks - The build now fails if code isn't formatted correctly
yurishkuro
reviewed
Sep 19, 2016
| @@ -14,7 +14,6 @@ ext.apacheThriftVersion = '0.9.3' | |||
| ext.jerseyVersion = '2.22.2' | |||
| ext.slf4jVersion = '1.7.16' | |||
| ext.jacksonVersion = '2.7.4' | |||
| ext.checkstyleVersion = '7.1.1' | |||
There was a problem hiding this comment.
I thought checkstyle checks not just the formatting, but the actual code mistakes, like go vet
There was a problem hiding this comment.
I don't think checkstyle is that intelligent. Findbugs is more similar to go vet
From wikipedia,
The performed checks mainly limit themselves to the presentation and don't analyze content, and do not confirm the correctness or completeness of the program.
yurishkuro
approved these changes
Sep 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks, so we solely rely on the formatter's checks