This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Introduce Clock interface for time measurements #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yurishkuro
commented
Sep 12, 2016
- Use nano-time for measuring duration
- Fix the tests, remove powermock dependency
- add more tests for duration calculation
- Use nano-time for measuring duration - Fix the tests, remove powermock dependency
|
@adriancole we discussed in the past how this lib used |
| } | ||
|
|
||
| @Override | ||
| public long currentTimeNanos() { |
There was a problem hiding this comment.
I'd probably not use the word "Time" here, eventhough nanoTime does. maybe tick or nanoTick? https://google.github.io/guava/releases/19.0/api/docs/com/google/common/base/Ticker.html
There was a problem hiding this comment.
reason is that people might be confused that it relates to the other "time" in this interface which it doesn't
|
naming bikeshed aside, looks good. |
| @@ -19,11 +19,8 @@ | |||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| * THE SOFTWARE. | |||
| */ | |||
| package com.uber.jaeger.filters.jaxrs2; | |||
| package com.uber.jaeger.context; | |||
There was a problem hiding this comment.
@oibe these tests weren't in the proper tests dir, so not sure if they were even exercised previously (intelliJ didn't understand them as tests)
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.