Default peer service name to blank as it is required in Thrift Endpoint #47
Conversation
| @@ -72,7 +72,7 @@ public Tracer getTracer() { | |||
| public Endpoint getPeer() { | |||
| synchronized (this) { | |||
| if (peer == null) { | |||
| peer = new Endpoint(); | |||
| peer = new Endpoint(0, (short) 0, ""); | |||
There was a problem hiding this comment.
might want to return null.. ex null endpoint is ok, it is null serviceName that's the problem. an empty endpoint w/o an ip or serviceName or port, is probably worse than null.
|
PS verified this fixes it! |
|
LGTM pending the null conversation. |
| @@ -21,15 +21,15 @@ | |||
| */ | |||
| package com.uber.jaeger; | |||
|
|
|||
| import com.twitter.zipkin.thriftjava.Endpoint; | |||
| import com.uber.jaeger.utils.Utils; | |||
| import io.opentracing.tag.Tags; | |||
There was a problem hiding this comment.
intelliJ kept insisting, so I let it
|
OK I figured it out. It was really a bug: reusing getPeer method as both lazy initializer and getter. I split them into plain getter and |
|
released as 0.8.1 |
|
thanks On Sat, Sep 10, 2016 at 4:29 AM, Yuri Shkuro notifications@github.com
|
Fixes #45