Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Address build warnings #455

Merged

Conversation

jpkrohling
Copy link
Collaborator

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

  • Clear up build warnings.

Short description of the changes

  • For each warning that was being shown, there's one small change either in the code or in the build file.

Before:

$ ./gradlew clean check

> Configure project :
0.29.1-SNAPSHOT

> Task :jaeger-core:compileJava
Note: /mnt/storage/jpkroehling/Projects/src/github.com/jaegertracing/jaeger-client-java/jaeger-core/src/main/java/io/jaegertracing/Configuration.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :jaeger-core:compileTestJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /mnt/storage/jpkroehling/Projects/src/github.com/jaegertracing/jaeger-client-java/jaeger-core/src/test/java/io/jaegertracing/ConfigurationTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :jaeger-core:test

io.jaegertracing.reporters.RemoteReporterTest > testCloseWhenQueueFull SKIPPED

> Task :jaeger-thrift:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6

> Task :jaeger-zipkin:compileTestJava
Note: /mnt/storage/jpkroehling/Projects/src/github.com/jaegertracing/jaeger-client-java/jaeger-zipkin/src/test/java/io/jaegertracing/zipkin/reporters/ZipkinV2ReporterTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.7/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 6s
59 actionable tasks: 47 executed, 12 up-to-date

After:

$ ./gradlew clean check

> Configure project :
0.29.1-SNAPSHOT

> Task :jaeger-core:test

io.jaegertracing.reporters.RemoteReporterTest > testCloseWhenQueueFull SKIPPED

> Task :jaeger-thrift:compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.6

BUILD SUCCESSFUL in 1m 13s
59 actionable tasks: 42 executed, 17 up-to-date

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@ghost ghost assigned jpkrohling Jun 18, 2018
@ghost ghost added the review label Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #455 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
- Coverage     88.35%   88.24%   -0.11%     
+ Complexity      489      488       -1     
============================================
  Files            63       63              
  Lines          1846     1846              
  Branches        240      240              
============================================
- Hits           1631     1629       -2     
- Misses          137      139       +2     
  Partials         78       78
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/jaegertracing/Configuration.java 94.14% <100%> (ø) 39 <0> (ø) ⬇️
...a/io/jaegertracing/propagation/B3TextMapCodec.java 86.53% <0%> (-3.85%) 19% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1c0b9...8cd3e28. Read the comment docs.

@pavolloffay pavolloffay merged commit 8b87ab7 into jaegertracing:master Jun 18, 2018
@ghost ghost removed the review label Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants