Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Enable the signing of the archives to be marked as not required if -P… #398

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

objectiser
Copy link
Contributor

…skipSigning=true commandline property is specified

Signed-off-by: Gary Brown gary@brownuk.com

…skipSigning=true commandline property is specified

Signed-off-by: Gary Brown <gary@brownuk.com>
@ghost ghost assigned objectiser Apr 13, 2018
@ghost ghost added the review label Apr 13, 2018
@objectiser
Copy link
Contributor Author

Relevant discussion - not sure if more recent updates to the docs, but it did seem to behave as described in this post, signing is performed regardless of the the value of the 'required' flag - but if cannot be performed will just skip if the 'required' flag is false.

So if the commandline property is not specified, then the behaviour should be unchanged.

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #398 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #398      +/-   ##
===========================================
+ Coverage     84.25%   84.3%   +0.04%     
- Complexity      500     501       +1     
===========================================
  Files            66      66              
  Lines          2033    2033              
  Branches        247     247              
===========================================
+ Hits           1713    1714       +1     
  Misses          239     239              
+ Partials         81      80       -1
Impacted Files Coverage Δ Complexity Δ
...aegertracing/samplers/RemoteControlledSampler.java 85.85% <0%> (+1.01%) 20% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb9374...16fbb40. Read the comment docs.

Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit 16fbb40 into jaegertracing:master Apr 13, 2018
@ghost ghost removed the review label Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants