Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

b3 codec test readability improvement. #358

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

tmszdmsk
Copy link
Contributor

IMHO it is easier to reason about this test in this form. I don't know what's the policy for adding test dependencies but can be further optimized with guava

@tmszdmsk
Copy link
Contributor Author

PR tests passed here but checks link still directs to old one. Probably some race condition: https://travis-ci.org/jaegertracing/jaeger-client-java/builds/346868442

@jpkrohling
Copy link
Collaborator

PR tests passed here but checks link still directs to old one

It's probably because there's a merge commit here. If you rebase and force push, it should work.

Signed-off-by: Tomasz Adamski <tadamski@wikia-inc.com>
@tmszdmsk tmszdmsk force-pushed the codec-b3-test-improvement branch from 161adc1 to 77bc668 Compare February 27, 2018 17:16
@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #358 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
+ Coverage     84.36%   84.61%   +0.24%     
  Complexity      614      614              
============================================
  Files            94       94              
  Lines          2444     2444              
  Branches        274      274              
============================================
+ Hits           2062     2068       +6     
+ Misses          285      279       -6     
  Partials         97       97
Impacted Files Coverage Δ Complexity Δ
...java/com/uber/jaeger/reporters/RemoteReporter.java 87.05% <0%> (+2.35%) 8% <0%> (ø) ⬇️
...jaeger/reporters/protocols/ThriftUdpTransport.java 84.74% <0%> (+3.38%) 14% <0%> (ø) ⬇️
...ain/java/com/uber/jaeger/senders/ThriftSender.java 77.55% <0%> (+4.08%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7565e06...77bc668. Read the comment docs.

@tmszdmsk
Copy link
Contributor Author

tmszdmsk commented Feb 27, 2018

If you rebase and force push, it should work.

Done!

Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro merged commit 7ad8233 into jaegertracing:master Feb 27, 2018
@tmszdmsk tmszdmsk deleted the codec-b3-test-improvement branch February 27, 2018 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants