Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

tests for malicious input for B3TextMapCodec #353

Closed

Conversation

tmszdmsk
Copy link
Contributor

Tests showing that B3TextMapCodec is vulnerable when an incorrect input is provided.

Signed-off-by: Tomasz Adamski <tadamski@wikia-inc.com>
@tmszdmsk tmszdmsk force-pushed the B3-codec-malicious-input branch from f47b13a to 6c5e884 Compare February 26, 2018 15:16
@jpkrohling
Copy link
Collaborator

Thanks for this PR! I think the test would be a better fit for B3TextMapCodecTest. Would you mind if I pick your commit and re-work it? I'll then also provide a fix, but you'll still be marked as "co-author" of the commit (I believe).

@tmszdmsk
Copy link
Contributor Author

@jpkrohling of course, I don't mind. Allow edit from maintainers. is checked on this PR.
Personally I am not a fan of grouping tests by class, but you are the mainainer of it so I don't mind.

@jpkrohling
Copy link
Collaborator

I'm closing this in favor of #355.

@jpkrohling jpkrohling closed this Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants