This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
This closes #256 by better handling baggage null values #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge value of null, but also removing existing baggage when their value has been updated as null Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
============================================
- Coverage 84.08% 84.01% -0.08%
- Complexity 568 570 +2
============================================
Files 91 91
Lines 2225 2227 +2
Branches 258 259 +1
============================================
Hits 1871 1871
- Misses 255 256 +1
- Partials 99 100 +1
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Dec 11, 2017
| final String value = "value"; | ||
| SpanContext ctx = setter.setBaggage(span, KEY, value); | ||
| Span child = (Span) tracer.buildSpan("some-operation").asChildOf(ctx).startManual(); | ||
| ctx = setter.setBaggage(child, KEY, null); |
There was a problem hiding this comment.
I would rather test this via span.setBaggage API, since it has additional null checks.
…checks Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
yurishkuro
approved these changes
Feb 1, 2018
|
thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #256 by ignoring attempts to set a new baggage value of null, but also removing existing baggage when their value has been updated as null
Signed-off-by: Babak Mozaffari bmozaffa@redhat.com