This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[jaeger-client-java] Span class does not report multiple time on multiple invocations of finish() #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple invocations of finish() Signed-off-by: Debosmit Ray <debo@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
============================================
+ Coverage 82.96% 83.01% +0.04%
- Complexity 551 553 +2
============================================
Files 91 91
Lines 2160 2166 +6
Branches 244 245 +1
============================================
+ Hits 1792 1798 +6
Misses 267 267
Partials 101 101
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Dec 1, 2017
| @@ -162,6 +163,11 @@ public void finish(long finishMicros) { | |||
|
|
|||
| private void finishWithDuration(long durationMicros) { | |||
| synchronized (this) { | |||
| if (finished) { | |||
| return; | |||
There was a problem hiding this comment.
would it make sense to log a warning?
There was a problem hiding this comment.
Yep - I think it does. It seems important to know that the subsequent calls to finish(), will have no real effect. Making the change.
yurishkuro
approved these changes
Dec 1, 2017
Signed-off-by: Debosmit Ray <debo@uber.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #295