This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Fix crossdock #203
Merged
Fix crossdock #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-adder
commented
Jun 26, 2017
travis/build-crossdock.sh
Outdated
| @@ -10,7 +10,7 @@ export TAG=`if [ "$BRANCH" == "master" ]; then echo "latest"; else echo "${BRANC | |||
| echo "TRAVIS_BRANCH=$TRAVIS_BRANCH, REPO=$REPO, PR=$PR, BRANCH=$BRANCH, TAG=$TAG" | |||
|
|
|||
| # Only push the docker container to Docker Hub for master branch | |||
| if [ "$BRANCH" == "master" ]; then echo 'upload to Docker Hub'; else echo 'skip docker upload for PR'; exit 0; fi | |||
| #if [ "$BRANCH" == "master" ]; then echo 'upload to Docker Hub'; else echo 'skip docker upload for PR'; exit 0; fi | |||
There was a problem hiding this comment.
will revert back after testing this works with other repos
yurishkuro
approved these changes
Jun 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=========================================
Coverage 80.22% 80.22%
Complexity 473 473
=========================================
Files 79 79
Lines 1846 1846
Branches 216 216
=========================================
Hits 1481 1481
Misses 274 274
Partials 91 91Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the environment variable is empty, default to UDP. This is breaking the crossdock tests for all jaeger repos.