Save baggage in span #189
Save baggage in span #189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
===========================================
+ Coverage 80.22% 80.43% +0.2%
- Complexity 473 476 +3
===========================================
Files 79 79
Lines 1846 1855 +9
Branches 216 218 +2
===========================================
+ Hits 1481 1492 +11
+ Misses 274 273 -1
+ Partials 91 90 -1
Continue to review full report at Codecov.
|
| io.opentracing.Span parent2 = tracer.buildSpan("foo").start(); | ||
| parent2.setBaggageItem("foo2", "bar"); | ||
| this.assertBaggageLogs(parent2, "foo2", "bar"); |
There was a problem hiding this comment.
That makes me think, should we also be recording new vs override of the baggage? We cannot reliably infer that from the full trace because the parent might set the baggage after the child has been started.
There was a problem hiding this comment.
iphone's autocorrect. I edited the question. When both parent and child spans set the same baggage key, we don't record if the child overrides the parent or not.
There was a problem hiding this comment.
I'll add fields.put("overwrite", True) to signify if we're doing a parent override.
|
Started a github project for it: https://github.com/uber/jaeger/projects/1 |
655aaec to
2e82315
Compare
| @@ -117,7 +117,18 @@ public String getOperationName() { | |||
| @Override | |||
| public Span setBaggageItem(String key, String value) { | |||
| synchronized (this) { | |||
| String prevItem = this.getBaggageItem(key); | |||
| this.context = this.context.withBaggageItem(key, value); | |||
Per https://github.com/uber/jaeger/issues/179