Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Pin errorprone version and thus javac version #128

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Conversation

vprithvi
Copy link
Contributor

  • The errorprone plugin pulls in the latest version of errorprone which
    replaces javac with a dev build of JDK9.
    JDK9 dev builds don't play well with lombok.
    This commit updates lombok/errorprone plugins and pins errorprone to a
    version that builds correctly

- The errorprone plugin pulls in the latest version of errorprone which
  replaces javac with a dev build of JDK9.
  JDK9 dev builds don't play well with lombok.
  This commit updates lombok/errorprone plugins and pins errorprone to a
  version that builds correctly
@vprithvi vprithvi self-assigned this Feb 27, 2017
@codecov-io
Copy link

Codecov Report

Merging #128 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
+ Coverage     81.11%   81.16%   +0.05%     
- Complexity      497      498       +1     
============================================
  Files            89       89              
  Lines          1885     1885              
  Branches        181      181              
============================================
+ Hits           1529     1530       +1     
  Misses          268      268              
+ Partials         88       87       -1
Impacted Files Coverage Δ Complexity Δ
.../uber/jaeger/samplers/RemoteControlledSampler.java 92.85% <0%> (+1.42%) 19% <0%> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04b583...0b08e4d. Read the comment docs.

@vprithvi vprithvi merged commit 7060308 into master Feb 27, 2017
@pavolloffay pavolloffay deleted the pin-javac-version branch April 9, 2018 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants