Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add xdock client service #122

Merged
merged 6 commits into from
Jan 27, 2017
Merged

Add xdock client service #122

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fa97cc
Add xdock client service
black-adder Jan 24, 2017
8f23acd
Address comments
black-adder Jan 25, 2017
96923c4
Fix issue
black-adder Jan 25, 2017
a69f581
Fix test
black-adder Jan 25, 2017
dac8750
Address comments
black-adder Jan 25, 2017
de3047a
Prithvi knows his Java
black-adder Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions jaeger-crossdock/src/main/java/com/uber/jaeger/crossdock/api/CreateTracesRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import lombok.Getter;
import lombok.ToString;

import java.util.Map;

@ToString
@Getter
public class CreateTracesRequest {
private String operation;
private int count;
Expand All @@ -42,16 +44,4 @@ public CreateTracesRequest(
this.count = count;
this.tags = tags;
}

public String getOperation() {
return operation;
}

public int getCount() {
return count;
}

public Map<String, String> getTags() {
return tags;
}
}
16 changes: 8 additions & 8 deletions ...rossdock/src/main/java/com/uber/jaeger/crossdock/resources/behavior/EndToEndBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,20 @@

public class EndToEndBehavior {

private static final Configuration cfg = new Configuration(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This doesn't really need to be a static field because nothing is writing to it

"crossdock-java",
// TODO make polling interval available for sampler
new Configuration.SamplerConfiguration("remote", 1, "test_driver:5778"),
new Configuration.ReporterConfiguration(null, "test_driver", 5775, 1000, null));

private io.opentracing.Tracer tracer;

public EndToEndBehavior() {
this(null);
this(cfg.getTracer());
}

public EndToEndBehavior(io.opentracing.Tracer tracer) {
final Configuration cfg = new Configuration(
"crossdock-java",
// TODO make polling interval available for sampler
new Configuration.SamplerConfiguration("remote", 1, "test_driver:5778"),
new Configuration.ReporterConfiguration(null, "test_driver", 5775, 1000, null));

this.tracer = (tracer != null) ? tracer : cfg.getTracer();
this.tracer = tracer;
}

public void GenerateTraces(CreateTracesRequest request) {
Expand Down