-
Notifications
You must be signed in to change notification settings - Fork 231
Define some classes internal #396
Comments
Looks like a meta issue. Do we have an inventory of what should be moved? |
Making this inventory would be part of the task. In general, I would say that anything non-core should be marked as "private". I would also take a white-listing approach for things in the core: place everything under "internal", and then move them out based on their expected consumption:
|
Resolves jaegertracing#396 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Resolves jaegertracing#396 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Resolves jaegertracing#396 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
When I wrote wrappers for jaeger there was one case where I had to use a package-protected method: Basically when passing wrapped From my point of view an ideal solution would be some better way to pass extra information from
One more issue I had is that my traceId/spanId are strings and converting them to long looses information, so I had to put my IDs into the baggage for a while anyway - to store them for later propagation to other services. Maybe it would make sense to create I could avoid all these by not implementing |
See #253 (comment)
Some classes should be moved to "internal" package to avoid public use.
The text was updated successfully, but these errors were encountered: