This repository has been archived by the owner on May 23, 2024. It is now read-only.
Move remote sampler to its own files #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
golangcibot
reviewed
Oct 15, 2019
sampler_remote_test.go
Outdated
| assert.Equal(t, test.expectedDefaultProbability, s.defaultSampler.SamplingRate()) | ||
|
|
||
| // First call is always sampled | ||
| sampled, tags := sampler.IsSampled(TraceID{Low: testMaxID + 10}, testOperationName) |
There was a problem hiding this comment.
SA4006: this value of tags is never used (from staticcheck)
vprithvi
approved these changes
Oct 15, 2019
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 84.69% 84.69%
=======================================
Files 33 33
Lines 1503 1503
=======================================
Hits 1273 1273
Misses 168 168
Partials 62 62Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are getting too large. No code changes here, just moving stuff around.
Part of # #449