This repository has been archived by the owner on May 23, 2024. It is now read-only.
Support delayed sampling decisions #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2019 17:52
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 84.69% 84.69%
=======================================
Files 33 33
Lines 1503 1503
=======================================
Hits 1273 1273
Misses 168 168
Partials 62 62Continue to review full report at Codecov.
|
vprithvi
approved these changes
Oct 14, 2019
added 4 commits
October 14, 2019 17:49
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
golangcibot
reviewed
Oct 15, 2019
tracer.go
Outdated
| t.metrics.SpansStartedDelayedSampling.Inc(1) | ||
| if newTrace { | ||
| t.metrics.TracesStartedDelayedSampling.Inc(1) | ||
| } else if sp.firstInProcess { |
There was a problem hiding this comment.
SA9003: empty branch (from staticcheck)
vprithvi
reviewed
Oct 15, 2019
| @@ -93,7 +93,7 @@ func (s *tracerSuite) TestBeginRootSpan() { | |||
| s.NotNil(ss.duration) | |||
|
|
|||
| s.metricsFactory.AssertCounterMetrics(s.T(), []metricstest.ExpectedMetric{ | |||
| {Name: "jaeger.tracer.finished_spans", Value: 1}, | |||
| {Name: "jaeger.tracer.finished_spans", Tags: map[string]string{"sampled": "y"}, Value: 1}, | |||
There was a problem hiding this comment.
I think we may want to tighten these tests by also asserting the length of these metrics to verify that nothing additional is emitted.
There was a problem hiding this comment.
I think that'd only make the tests more fragile. The objective here is to test that some specific metrics are emitted.
Signed-off-by: Yuri Shkuro <ys@uber.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of # #449