Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Remove go modules #425

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 6, 2019

According to jaegertracing/jaeger-lib#75 (comment), enabling go modules is more complicated when the library is on a version above 1.x, which is the case with jaeger-client-go and jaeger-lib.

For now, removing go modules. Will revisit in the future along with potential renaming of the path from /uber/ to /jaegertracing/

Reopens #382

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          22       22           
  Lines        1625     1625           
=======================================
  Hits         1496     1496           
  Misses         87       87           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3434ad5...5558713. Read the comment docs.

@yurishkuro yurishkuro merged commit 0ba3a02 into jaegertracing:master Sep 6, 2019
@yurishkuro yurishkuro deleted the remove-gomodules branch September 6, 2019 18:57
@F21
Copy link
Contributor

F21 commented Sep 10, 2019

It looks like the go.mod and go.sum files were not removed, so the latest release (2.18.0) can't be installed using go modules.

@yurishkuro
Copy link
Member Author

The previous releases couldn't be installed with go modules either.

@F21
Copy link
Contributor

F21 commented Sep 10, 2019

2.17.0 is installable as v2.17.0+incompatible because there are no go.mod and go.sum files in the release: https://github.com/jaegertracing/jaeger-client-go/tree/85825f3f682a6fb24b12a4604be2a101432c7534

2.18.0 fails with go get github.com/uber/jaeger-client-go@v2.18.0: github.com/uber/jaeger-client-go@v2.18.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

@yurishkuro
Copy link
Member Author

Ah, sorry, I see what you mean. I will remove mod files and do another release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants