This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add "sampleWithoutDebugFlag" option for tracer to decide set/not set debug flag when a span is forced to be sampled #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 4, 2019
config/options.go
Outdated
| reporter jaeger.Reporter | ||
| sampler jaeger.Sampler | ||
| contribObservers []jaeger.ContribObserver | ||
| observers []jaeger.Observer |
There was a problem hiding this comment.
SA1019: jaeger.Observer is deprecated: use jaeger.ContribObserver instead. (from staticcheck)
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=========================================
+ Coverage 88.46% 88.5% +0.04%
=========================================
Files 55 55
Lines 3111 3123 +12
=========================================
+ Hits 2752 2764 +12
Misses 255 255
Partials 104 104
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Sep 4, 2019
vprithvi
reviewed
Sep 4, 2019
golangcibot
reviewed
Sep 5, 2019
| reporter jaeger.Reporter | ||
| sampler jaeger.Sampler | ||
| contribObservers []jaeger.ContribObserver | ||
| observers []jaeger.Observer |
There was a problem hiding this comment.
SA1019: jaeger.Observer is deprecated: use jaeger.ContribObserver instead. (from staticcheck)
vprithvi
reviewed
Sep 5, 2019
yurishkuro
reviewed
Sep 5, 2019
yurishkuro
approved these changes
Sep 5, 2019
…debug span when a span is forced to be sampled Signed-off-by: jung <jung@uber.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes