Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Vendor Thrift code #303

Merged
merged 9 commits into from
Apr 30, 2018
Merged

Vendor Thrift code #303

merged 9 commits into from
Apr 30, 2018

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Thrift 0.11 has backwards incompatible changes, which prevents go get install. Granted, that method of dependency management is discouraged anyway. In any case, whichever version of thrift we pick we will cause incompatibilities for some applications.

Resolves #184

Short description of the changes

The portion of Apache Thrift library is copied into thrift directory as vendored code.

Yuri Shkuro added 6 commits April 27, 2018 22:28
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   86.79%   86.79%           
=======================================
  Files          54       54           
  Lines        2954     2954           
=======================================
  Hits         2564     2564           
  Misses        275      275           
  Partials      115      115
Impacted Files Coverage Δ
testutils/udp_transport.go 58.06% <ø> (ø) ⬆️
transport/http.go 81.66% <ø> (ø) ⬆️
transport/zipkin/http.go 75.43% <ø> (ø) ⬆️
transport_udp.go 92.59% <ø> (ø) ⬆️
utils/udp_client.go 0% <ø> (ø) ⬆️
testutils/mock_agent.go 81.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7476e1f...236e585. Read the comment docs.

Yuri Shkuro added 3 commits April 28, 2018 00:02
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro requested a review from black-adder April 29, 2018 20:25
Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I guess that's one way to do it

@vprithvi
Copy link
Contributor

I think we should have something equivalent to maven's enforcer plugin to ensure that this dependency isn't accidentally reintroduced transitively.

Maybe adding a grep for the thrift library in gopkg.lock, and glide.lock and making the build pass based on the result could achieve this.

@yurishkuro yurishkuro merged commit c6d8cc0 into master Apr 30, 2018
@yurishkuro yurishkuro deleted the vendor-thrift branch April 30, 2018 15:16
yurishkuro added a commit that referenced this pull request Apr 30, 2018
- Support throttling for debug traces (#274) <Isaac Hier>
- Remove dependency on Apache Thrift (#303) <Yuri Shkuro>
- Remove dependency on tchannel  (#295) (#294) <Yuri Shkuro>
- Test with Go 1.9 (#298) <Yuri Shkuro>

Signed-off-by: Yuri Shkuro <ys@uber.com>
at15 added a commit to dyweb/go.ice that referenced this pull request May 4, 2018
- jaegertracing/jaeger-client-go#303
- gommon released 0.0.6, a typo caused breaking change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants