This repository has been archived by the owner on May 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 86.79% 86.79%
=======================================
Files 54 54
Lines 2954 2954
=======================================
Hits 2564 2564
Misses 275 275
Partials 115 115
Continue to review full report at Codecov.
|
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
black-adder
approved these changes
Apr 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I guess that's one way to do it
I think we should have something equivalent to maven's enforcer plugin to ensure that this dependency isn't accidentally reintroduced transitively. Maybe adding a grep for the thrift library in |
yurishkuro
added a commit
that referenced
this pull request
Apr 30, 2018
at15
added a commit
to dyweb/go.ice
that referenced
this pull request
May 4, 2018
- jaegertracing/jaeger-client-go#303 - gommon released 0.0.6, a typo caused breaking change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Thrift 0.11 has backwards incompatible changes, which prevents
go get
install. Granted, that method of dependency management is discouraged anyway. In any case, whichever version of thrift we pick we will cause incompatibilities for some applications.Resolves #184
Short description of the changes
The portion of Apache Thrift library is copied into
thrift
directory as vendored code.