Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Implement ForeachBaggageItem #15

Merged
merged 1 commit into from
Jun 28, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions span.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,14 @@ func (s *span) BaggageItem(key string) string {
return s.baggage[key]
}

func (s *span) ForeachBaggageItem(handler func(k, v string)) {
s.RLock()
defer s.RUnlock()
for k, v := range s.baggage {
handler(k, v)
}
}

func (s *span) Tracer() opentracing.Tracer {
return s.tracer
}
Expand Down
21 changes: 21 additions & 0 deletions span_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package jaeger

import (
"github.com/stretchr/testify/assert"
"testing"
)

func TestBaggageIterator(t *testing.T) {
tracer, closer := NewTracer("DOOP", NewConstSampler(true), NewNullReporter())
defer closer.Close()

sp1 := tracer.StartSpan("s1").(*span)
sp1.SetBaggageItem("Some_Key", "12345")
sp1.SetBaggageItem("Some-other-key", "42")

b := make(map[string]string)
sp1.ForeachBaggageItem(func(k, v string) {
b[k] = v
})
assert.Equal(t, map[string]string{"some-key": "12345", "some-other-key": "42"}, b)
}
2 changes: 1 addition & 1 deletion tracer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (s *tracerSuite) TestBeginRootSpan() {
ss := sp.(*span)
s.NotNil(ss.tracer, "Tracer must be referenced from span")
s.Equal("get_name", ss.operationName)
s.Equal("s", ss.spanKind, "Span must be server-side")
s.Equal("server", ss.spanKind, "Span must be server-side")
s.Equal("peer-service", ss.peer.ServiceName, "Client is 'peer-service'")

s.EqualValues(someID, ss.traceID)
Expand Down