This repository has been archived by the owner on May 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 289
Structured stdout reporter #442
Comments
I don't have objections to adding getters to Span. |
mkorolyov
added a commit
to humans-group/jaeger-client-go
that referenced
this issue
Oct 11, 2019
Missed Getters where added so internal Span data became available outside of the package. Fixes jaegertracing#442. Signed-off-by: Maxim Korolyov <korolyov.maxim@gmail.com>
mkorolyov
added a commit
to humans-group/jaeger-client-go
that referenced
this issue
Oct 11, 2019
Missed Getters where added so internal Span data became available outside of the package. Fixes jaegertracing#442. Signed-off-by: Maxim Korolyov <korolyov.maxim@gmail.com>
mkorolyov
added a commit
to humans-group/jaeger-client-go
that referenced
this issue
Oct 13, 2019
Missed Getters where added so internal Span data became available outside of the package. Fixes jaegertracing#442. Signed-off-by: Maxim Korolyov <korolyov.maxim@gmail.com>
yurishkuro
pushed a commit
that referenced
this issue
Oct 15, 2019
Missed Getters where added so internal Span data became available outside of the package. Fixes #442. Signed-off-by: Maxim Korolyov <korolyov.maxim@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Requirement - what kind of business use case are you trying to solve?
Hi, i want to report spans to stdout in structured format(e.g. JSON).
Problem - what in Jaeger blocks you from solving the requirement?
There is already
Logger Reporter
but it logs not structured span(span.String()
) and span itself is very limited, not tags, no flags, operation name, etc.Proposal - what do you suggest to solve the problem or improve the existing situation?
I want to contribute if it is acceptable. There are several ways we can achieve structured stdout:
Span
fields(e.g.Getters
) or add new struct with public fields so anyone who needs will have possibility to implementReporter
the way he needs with access to full span data.Any open questions to address
I'm prefer first approach for my self as it is more generalized one and provides more flexibility.
WDYT?
The text was updated successfully, but these errors were encountered: