Add language prefix to Jaeger client version tag

Signed-off-by: Isaac Hier <isaachier@gmail.com>
jaegertracing · Dec 17, 2017 · b8c769a · b8c769a
1 parent bd39a6a
commit b8c769a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/jaegertracing/Constants.h.in b/src/jaegertracing/Constants.h.in
@@ -21,7 +21,7 @@
 
 namespace jaegertracing {
 
-static constexpr auto kJaegerClientVersion = "@PROJECT_VERSION@";
+static constexpr auto kJaegerClientVersion = "C++-@PROJECT_VERSION@";
 static constexpr auto kJaegerClientVersionTagKey = "jaeger.version";
 static constexpr auto kJaegerDebugHeader = "jaeger-debug-id";
 static constexpr auto kJaegerBaggageHeader = "jaeger-baggage";

diff --git a/src/jaegertracing/TracerTest.cpp b/src/jaegertracing/TracerTest.cpp
@@ -122,6 +122,17 @@ TEST(Tracer, testTracer)
     const auto tracer =
         std::static_pointer_cast<Tracer>(opentracing::Tracer::Global());
 
+    auto tagItr =
+        std::find_if(std::begin(tracer->tags()),
+                     std::end(tracer->tags()),
+                     [](const Tag& tag) {
+                         return tag.key() == kJaegerClientVersionTagKey;
+                     });
+    ASSERT_NE(std::end(tracer->tags()), tagItr);
+    ASSERT_TRUE(tagItr->value().is<const char*>());
+    ASSERT_EQ("C++-",
+        static_cast<std::string>(tagItr->value().get<const char*>()).substr(0, 4));
+
     opentracing::StartSpanOptions options;
     options.tags.push_back({ "tag-key", 1.23 });