Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] updated cassandra sub chart to use bitnami #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Jaeger] updated cassandra sub chart to use bitnami #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions charts/jaeger/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dependencies:
- name: cassandra
repository: https://charts.helm.sh/incubator
version: 0.15.3
repository: https://charts.bitnami.com/bitnami
version: 12.0.4
- name: elasticsearch
repository: https://charts.bitnami.com/bitnami
version: 20.0.4
Expand All @@ -10,6 +10,6 @@ dependencies:
version: 26.6.2
- name: common
repository: https://charts.bitnami.com/bitnami
version: 2.19.1
digest: sha256:16dad4387f2b392d5034731f997518ff05b77909220ce45ee6dd69664942f2df
generated: "2024-04-11T08:42:48.824851-04:00"
version: 2.27.0
digest: sha256:4c588cadf15870e63ec57671a61522514073041294860b0d696a4f32c97d622e
generated: "2024-11-21T23:42:24.535194222+05:30"
4 changes: 2 additions & 2 deletions charts/jaeger/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ maintainers:
email: jkowall@kowall.net
dependencies:
- name: cassandra
version: 0.15.3
repository: https://charts.helm.sh/incubator
version: 12.0.4
repository: https://charts.bitnami.com/bitnami
condition: provisionDataStore.cassandra
- name: elasticsearch
version: 20.0.4
Expand Down
22 changes: 16 additions & 6 deletions charts/jaeger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,25 @@ storage:

# Begin: Override values on the Cassandra subchart to customize for Jaeger
cassandra:
replicaCount: 1

resources:
type: "small"

persistence:
# To enable persistence, please see the documentation for the Cassandra chart
enabled: false
config:
cluster_name: jaeger
seed_size: 1
dc_name: dc1
rack_name: rack1
endpoint_snitch: GossipingPropertyFileSnitch

cluster:
name: jaeger
datacentre: dc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"centre", British spelling - is this correct?

Copy link
Contributor

@pavelnikolov pavelnikolov Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should be in the output yaml.
@yurishkuro good catch! It is cluster.datacenter according to the docs.

rack: rack1
endpointSnitch: GossipingPropertyFileSnitch
numTokens: 16
seedCount: 1
# jvm:
# maxHeapSize: 512M
# heapNewSize: 128M
# End: Override values on the Cassandra subchart to customize for Jaeger

# Begin: Override values on the Kafka subchart to customize for Jaeger
Expand Down
Loading