fix(page-list): enforce intended behavior on GitHub-pages hosted websites #1685
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github pages hosted sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I've been scratching my head for a while trying to figure out why URLs on my Quartz GitHub Pages site were occasionally missing the repo name:
Desired URL: https://username.github.io/repo-name/a/b/c
Obtained URL: https://username.github.io/a/b/c
This discrepancy often led to frustrating 404 errors.
After some digging, I came across this issue and its corresponding fix. While the original fix addressed the issue for specific cases, I realized I was encountering the same problem but with the PageList component. 😄
This PR proposes a similar solution: adding a trailing slash to folder URLs to ensure pathResolution works correctly, by prevent landing on URLs that are missing a slash.
Thank you for your time and consideration! I'm happy to provide more details if needed. 😊
Best regards,
Antoine