Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support CSS Modules #18

Closed
es-repo opened this issue Sep 17, 2017 · 7 comments · Fixed by #20
Closed

Doesn't support CSS Modules #18

es-repo opened this issue Sep 17, 2017 · 7 comments · Fixed by #20

Comments

@es-repo
Copy link

es-repo commented Sep 17, 2017

Unfortunately it doesn't support Vue SFC with CSS Modules. Do you have planes to add this?

@jackmellis
Copy link
Owner

I haven't played around with CSS Modules much, but it would be good to support it. I can have a look into when I next get a minute, or I'd welcome a PR :)

@es-repo
Copy link
Author

es-repo commented Sep 18, 2017

Working on it. Wouldn't you mind if I refactor index.js a little bit?

@jackmellis
Copy link
Owner

Great! What did you have in mind?

@es-repo
Copy link
Author

es-repo commented Sep 19, 2017

I'm going to process css-module styles with postcss+postss-modules to get json object with css classes and inject it into Vue component as computed property.

@es-repo
Copy link
Author

es-repo commented Sep 19, 2017

Please check out the pull request.

jackmellis added a commit that referenced this issue Sep 19, 2017
CSS Modules support
closes #18
@jackmellis
Copy link
Owner

@es-repo thanks a lot for this!

@es-repo
Copy link
Author

es-repo commented Sep 19, 2017

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants