Specialized Python exceptions #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b837f0 to
29e9dc6
Compare
nvictus
commented
Apr 10, 2024
Comment on lines
+1462
to
1603
| BBIReadRaw::BigBedFile(_) | BBIReadRaw::BigBedFileLike(_) => { | ||
| return Err(BBIFileClosed::new_err("Not a bigWig.")) | ||
| } | ||
| #[cfg(feature = "remote")] | ||
| BBIReadRaw::BigBedRemote(_) => return Err(BBIFileClosed::new_err("Not a bigWig.")), |
There was a problem hiding this comment.
Are these error types / messages correct?
There was a problem hiding this comment.
Ah that doesn't look right. Not sure the right exception but it shouldn't be file closed.
Thinking about it, could make BigWig and BigBed subclasses which effectively have no differences except extra methods.
Or just also implement this for bigBeds akin to values.
1d796d9 to
8318a0c
Compare
a84f7cc to
f4160f4
Compare
Update test_bigwig tests Linting Update tests Update tests Add bigbed fixture Update tests Add test for info method
Update docstrings
f4160f4 to
4241744
Compare
ci: Install pybigtools[test] for testing
4241744 to
0591832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptionraises withValueError,KeyError,BBIFileClosedorBBIReadError.b.chroms(chrom)will raise aKeyErrorinstead of returning None ifchromdoes not exist. This seems less surprising to me. The former behavior can be achieved more explicitly withb.chroms().get(chrom).opensupportpathlib.Pathobjects.chromandendargs optional forb.values()as inrecordsandzoom_records.