Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agnes template #589

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Conversation

kyluca
Copy link
Contributor

@kyluca kyluca commented Mar 4, 2021

New template: https://knowyourmeme.com/memes/agnes-harkness-winking

template

Also ran into a weird error when trying to test locally, not sure if you've seen this one before? When attempting to access the new template locally at http://localhost:5000/images/agnes, it doesn't display an image and the filepath it reports saving to below doesn't exist?

 $  make run
poetry run honcho start --procfile Procfile.dev
21:18:57 system | api.1 started (pid=113364)
21:18:57 system | site.1 started (pid=113365)
21:18:58 site.1 | INFO    -  Building documentation...
21:18:58 site.1 | INFO    -  Cleaning site directory
21:18:58 site.1 | INFO    -  Documentation built in 0.06 seconds
21:18:58 site.1 | [I 210304 21:18:58 server:335] Serving on http://localhost:5001
21:18:58 site.1 | [I 210304 21:18:58 handlers:62] Start watching changes
21:18:58 site.1 | [I 210304 21:18:58 handlers:64] Start detecting changes
21:18:58 api.1  | [2021-03-04 21:18:58 +1000] [113368] [INFO] Goin' Fast @ http://0.0.0.0:5000
21:18:58 api.1  | [2021-03-04 21:18:58 +1000] [113368] [INFO] Starting worker [113368]
21:19:11 api.1  | [2021-03-04 21:19:11 +1000] [113368] [INFO] Saving meme to /home/kyle/repos/memegen/images/agnes/_/i_have_read_and_agree_to_the_terms_and_conditions.a57c2b5cffe197383d2f3fcacced4f8f6c1358f6.png
21:19:11 api.1  | munmap_chunk(): invalid pointer

@jacebrowning
Copy link
Owner

it doesn't display an image

Weird. When I visit http://localhost:5000/images/agnes, I'm redirected to http://localhost:5000/images/agnes/_/i_have_read_and_agree_to_the_terms_and_conditions which displays this image:

the filepath it reports saving to below doesn't exist

Which parts of that file path do exist?

munmap_chunk(): invalid pointer

That sounds like this issue if you want to do some digging: python-pillow/Pillow#4225

Copy link
Owner

@jacebrowning jacebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this because the changes looks good despite the error you experienced. Thanks for the new template!

@jacebrowning jacebrowning merged commit a22c992 into jacebrowning:main Mar 5, 2021
@jacebrowning jacebrowning mentioned this pull request Mar 6, 2021
@kyluca
Copy link
Contributor Author

kyluca commented Mar 8, 2021

Thanks Jace, yeah that does seem to be related to the error I was getting locally (OS: Manjaro as some others in there reported). Also tried the updated dependencies from #591 but unfortunately still not producing an image. The logged path up to /home/kyle/repos/memegen/images/agnes/_/ does exist, but the final file i_have_read_and_agree_to_the_terms_and_conditions.a57c2b5cffe197383d2f3fcacced4f8f6c1358f6.png doesn't. Although we do get a new error:

 $  make run
poetry run honcho start --procfile Procfile.dev
15:51:20 system | api.1 started (pid=13872)
15:51:20 system | site.1 started (pid=13873)
15:51:21 site.1 | INFO    -  Building documentation...
15:51:21 site.1 | INFO    -  Cleaning site directory
15:51:21 site.1 | INFO    -  Documentation built in 0.06 seconds
15:51:21 site.1 | [I 210308 15:51:21 server:335] Serving on http://localhost:5001
15:51:21 site.1 | [I 210308 15:51:21 handlers:62] Start watching changes
15:51:21 site.1 | [I 210308 15:51:21 handlers:64] Start detecting changes
15:51:21 api.1  | [2021-03-08 15:51:21 +1000] [13876] [INFO] Goin' Fast @ http://0.0.0.0:5000
15:51:21 api.1  | [2021-03-08 15:51:21 +1000] [13876] [INFO] Starting worker [13876]
15:51:32 api.1  | [2021-03-08 15:51:32 +1000] [13876] [INFO] Saving meme to /home/kyle/repos/memegen/images/agnes/_/i_have_read_and_agree_to_the_terms_and_conditions.a57c2b5cffe197383d2f3fcacced4f8f6c1358f6.png
15:51:32 api.1  | corrupted size vs. prev_size

No worries though, looks like I might just have to wait for Pillow's fix to be released in a future version 👍

Thanks for finding that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants