Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadPrismLang doesn't handle dependencies #22

Closed
RunDevelopment opened this issue May 28, 2019 · 0 comments · Fixed by #23
Closed

loadPrismLang doesn't handle dependencies #22

RunDevelopment opened this issue May 28, 2019 · 0 comments · Fixed by #23

Comments

@RunDevelopment
Copy link

Hi!
I'm one of the maintainers of PrismJS and we had this issue here.
The cause of the problem is that loadPrismLang doesn't handle languages dependencies, e.g. C++ requiring C.

This should be quite easy to fix however as Prism provides a loadLanguages function which handles all dependencies for you. The usage of this function is described here under "Usage with Node".
@RunDevelopment RunDevelopment mentioned this issue May 28, 2019
Closed
straicat added a commit to straicat/markdown-it-prism that referenced this issue May 28, 2019
@straicat
use loadLanguages to load languages
2769fba 
Fix: jGleitz#22  `loadPrismLang` doesn't handle languages dependencies, e.g. C++ requiring C.
@straicat straicat mentioned this issue May 28, 2019
Merged
jGleitz pushed a commit that referenced this issue May 29, 2019
@straicat @jGleitz
use loadLanguages to load languages (#23)
425dc86 
* use `loadLanguages` to load languages

Fix: #22  `loadPrismLang` doesn't handle languages dependencies, e.g. C++ requiring C.

* Remove obsolete try-catch

* Add test case for rendering C++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use loadLanguages to load languages straicat/markdown-it-prism
1 participant
@RunDevelopment